Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
111 stars 176 forks source link

APIView wrongfully treating some `std::vector<>` members as `int` members. #1309

Open katmsft opened 3 years ago

katmsft commented 3 years ago

Source: https://apiview.dev/Assemblies/Review/5aec114a35f946ba9ee31e0955b69fea

Search for Response<Models::CommitBlockListResult> CommitBlockList. const int & blockIds, is shown, however the code is: https://github.com/Azure/azure-sdk-for-cpp/blob/master/sdk/storage/azure-storage-blobs/inc/azure/storage/blobs/block_blob_client.hpp#L201 const std::vector<std::string>& blockIds,

Command used:

DataLake:

clang++ .\sdk\storage\azure-storage-files-datalake\inc\azure\storage\files\datalake.hpp -I .\sdk\storage\azure-storage-files-datalake\inc -I .\sdk\core\azure-core\inc -Xclang -ast-dump -I .\sdk\storage\azure-storage-common\inc -I .\sdk\storage\azure-storage-blobs\inc > Azure_Storage_Files_Datalake.ast

Compress-Archive Azure_Storage_Files_Datalake.ast -DestinationPath Azure_Storage_Files_Datalake.zip

Rename-Item Azure_Storage_Files_Datalake.zip -NewName Azure_Storage_Files_Datalake.cppast

File:

clang++ .\sdk\storage\azure-storage-files-shares\inc\azure\storage\files\shares.hpp -I .\sdk\storage\azure-storage-files-shares\inc -I .\sdk\core\azure-core\inc -Xclang -ast-dump -I .\sdk\storage\azure-storage-common\inc > Azure_Storage_Files_Shares.ast

Compress-Archive Azure_Storage_Files_Shares.ast -DestinationPath Azure_Storage_Files_Shares.zip

Rename-Item Azure_Storage_Files_Shares.zip -NewName Azure_Storage_Files_Shares.cppast

Blob:

clang++ .\sdk\storage\azure-storage-blobs\inc\azure\storage\blobs.hpp -I .\sdk\storage\azure-storage-blobs\inc -I .\sdk\core\azure-core\inc -Xclang -ast-dump -I .\sdk\storage\azure-storage-common\inc > Azure_Storage_Blobs.ast

Compress-Archive Azure_Storage_Blobs.ast -DestinationPath Azure_Storage_Blobs.zip

Rename-Item Azure_Storage_Blobs.zip -NewName Azure_Storage_Blobs.cppast

kurtzeborn commented 3 years ago

Marking this "Client" for now since this will likely need to be done by the C++ team.