Closed danieljurek closed 2 years ago
github IO read from release csv. If Hide=true
, then we do not display it in toc.
I believe current github pages have the right setup
For docs.ms, our new approach is trying to sync with release csv, which filter out the package hide=true. It helps with this issue too.
The template only got updates only through template release pipeline for testing purpose. If we do not want to have the template, then we can remove it from matadata/azure-template.json and ci-configs/preview.json
We currently maintain the exclude list. We can put template over there. https://github.com/Azure/azure-sdk-for-python/blob/main/eng/scripts/Language-Settings.ps1#L196
Two changes:
ci-config/preview.json|ci-config/latest.json
in docindex dealing with main branch.
https://github.com/Azure/azure-sdk-for-python/blob/main/eng/pipelines/docindex.ymlCovered cases:
DailyUpdate | Release | |
---|---|---|
In template testing | Comment out template from exclude list | 1. Comment out template from exclude list 2. Add variable of skip removing step if necessary |
Not in testing | Nothing | Nothing |
@weshaggard and I discussed another option that helps us preserve commit history to show the change. Here's my view on how it could be implemented.
/metadata
folder in docs repo TestPipeline
(set to true
in the case of Template pipelines) into git-push-changes.yml
TestPipeline
is true
then before push (inside of git-push-changes.yml
):
CommitMsg
This means that the file state in the repo doesn't change but the template run makes the changes that would've been made. One can always look back through the commit history to see what the changes would've been.
We use a similar strategy with this when testing publishing updates to the vcpkg
repository. In this case vcpkg
is an active public git repository and we don't want our PRs to introduce noise. When we open a PR (opening PRs is how you release in vcpkg
) we immediately close the PR once it's opened. This way we can see the effects of the system without cluttering contributors' experience: https://github.com/microsoft/vcpkg/pull/20081
Template currently set 'Hide' to 'true'. Issue has been resolved. Closed the issue.
Template packages do not need to be released to the docs site, but they're useful for validating our release pipelines. Future work should take this into account and probably: