Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
114 stars 180 forks source link

Typo when there is failure to load product list #5233

Closed mayurid closed 1 year ago

mayurid commented 1 year ago

Product: PPE-1.0.0-beta.3 Continue is spelt wrong.

image

mayurid commented 1 year ago

Additive nit: Overall, this UI needs some attention and UX love. I would update the message with "Failed to load...." or "Failure to load....." Also I am unclear on what are the next steps that i can do if i press continue?

JonathanCrd commented 1 year ago

@mayurid thanks for the comments. I'm gonna fix this as part of https://github.com/Azure/azure-sdk-tools/issues/5699

I'm thinking of replacing 'Failed to load product list' for something else, like 'Could not find any products associated with '. There are scenarios in which the service does not have any product at all (yet), so it's not like something is 'failing'.

JonathanCrd commented 1 year ago

Fixed the typo and improved the message. Also, based on the comments to improve the UX, and discussions regarding https://github.com/Azure/azure-sdk-tools/issues/5699 to make this action more explicit, I got rid of the warning window at all and instead replaced it with an in-line warning message. The submit button will be disabled until the user checks that checkbox.

image

Since we will be working on a UI redesign soon, I tried to follow @ccbarragan design design, so it's easier for us to migrate this alerts in the future. To be clear, I'm not working on the redesign yet.