Close GitHub Issues (proposed for dilithium-1H)

[ronniegeraghty]

When someone schedules a SDK Architecture Board Review, a GitHub issues is created to collect many of the materials teams need to bring to the review session and to work with the teams in making sure their materials meet our standards. Once the meeting has concluded and the meeting recording link has been added to the issue, the issue should be closed to keep our repos clean. It would be nice if the scheduling tool could:

1. Add the link to the meeting recording once the meeting has concluded.
2. Close the GitHub issues after the recording link has been added.

[maririos]

Add the link to the meeting recording once the meeting has concluded.

The scheduler tool doesn't start the recording, which means it doesn't own it. The link won't be available for us. There might be a way to get it but we need to check permissions. maybe https://techcommunity.microsoft.com/t5/teams-developer/graph-api-ms-teams-meeting-recording-link/m-p/1994894

Close the GitHub issues after the recording link has been added.

Is there any label that it is added to the issue when a meeting is concluded so automation could be written? Talking with @ladonnaq this could help in the Release Planner app to know that a meeting happened.

[ronniegeraghty]

There is no label that is added when the review session is completed, and I feel adding a step to add a label would re-add the manual step here we are trying to remove.

[maririos]

Understandable. Another option is that when a Release Plan is associated with a GH issue and the Release Plan is completed, then the GH issue can be closed. It might not capture all of the teams as that will imply everyone is using the Release Planner, but it will help.

@ronniegeraghty what do you think?

[ladonnaq]

There is no label that is added when the review session is completed, and I feel adding a step to add a label would re-add the manual step here we are trying to remove.

There needs to a trigger to indicate that the GitHub issue should be closed or else we cannot automate closing the GitHub issue. @maririos If you can figure out how to get the recording of the meeting, could that be the trigger that the meeting has been completed and when the link is added the issue is closed? Is there a one-to-one mapping between arch board scheduled meetings and GitHub issues? In other words, is a GitHub issue created for every scheduled meeting for arch board?

[maririos]

could that be the trigger that the meeting has been completed and when the link is added the issue is closed

If someone is manually adding the link, might as well close the issue too, no? They can do Close with comment so no automation needed

[ronniegeraghty]

One possible option would be to close the issue 24 hours after the meeting start time. Thoughts? I'll have to check with the rest of the arch board team, but I haven't seen many or any instances when the issue is used after the meeting besides to post the recording.

[maririos]

The Recording link can always be added to the issue if th eissue is closed, so this should work. And in this case, we know the meeting happened because you are making sure that people are ready for the meeting and if not you move it

[ronniegeraghty]

Question: Can you reschedule a past meeting? Or if the meeting time has passed, the meeting can no longer be updated?

[maririos]

Question: Can you reschedule a past meeting? Or if the meeting time has passed, the meeting can no longer be updated?

You have just discovered a bug!! If someone has the direct link, then they can re-schedule/update the meeting. The link will always be present on the GH issue and in the calendar invite. (issue created => https://github.com/Azure/azure-sdk-tools/issues/6265) If they go directly to the Scheduler App, or the Admin App, they won't see the meeting.