search

Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
113 stars 177 forks source link

[Breaking Change] azure-rest-api-specs-pr pipeline failing to mark PR with "BreakingChangesReviewRequired" #5623

Open mikekistler opened 1 year ago

mikekistler commented 1 year ago

The PR pipeline bot in azure-rest-api-specs-pr failed to add the "BreakingChangesReviewRequired" label to https://github.com/Azure/azure-rest-api-specs-pr/pull/11562 when this PR failed the "Breaking Change (Cross-Version)" PR check:

image

mikekistler commented 1 year ago

Here's another instance: https://github.com/Azure/azure-rest-api-specs-pr/pull/11560

mikekistler commented 1 year ago

Another instance: https://github.com/Azure/azure-rest-api-specs-pr/pull/11517

This PR is failing the “Swagger Breaking Change” PR Check:

image

But the pipeline did not add the “BreakingChangesReviewRequired” label (maybe because the break is only to a preview api-version in the internal repo?).

The PR reviewer decided to add the label by hand:

image

About a week later the pipeline was retriggered and the bot removed the label:

image

In this particular case, a review is needed because the changes in the PR violate our Breaking Change policy – breaking changes are allowed when the break is to a prior preview and not a GA version, but only if the break is done in a new api-version, which was not the case here.

konrad-jamrozik commented 1 year ago

Related email thread for few people involved in the issue discussion:

Sent: Friday, March 17, 2023 8:00 AM
Subject: Breaking Changes labeling in the azure-rest-api-specs repo