search

Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
114 stars 177 forks source link

[LintDiff][False positive] support request by Tarun Sharma: incorrect RequiredPropertiesMissingInResourceModel #5801

Open konrad-jamrozik opened 1 year ago

konrad-jamrozik commented 1 year ago

Please see here

tarsharm commented 1 year ago

Link to the pipeline where error is seen - https://dev.azure.com/azure-sdk/internal/_build/results?buildId=2604647&view=ms.vss-test-web.build-test-results-tab

konrad-jamrozik commented 1 year ago

@raych1 confirmed in the Teams thread that LintDiff appears to report a false positive.

konrad-jamrozik commented 1 year ago

Some details of the bogus error:

<html>
<body>
<!--StartFragment-->

Rule
--
❌ RequiredPropertiesMissingInResourceModel

<!--EndFragment-->
</body>
</html>Rule
❌ [RequiredPropertiesMissingInResourceModel](https://github.com/Azure/azure-openapi-validator/blob/main/docs/required-properties-missing-in-resource-model.md)  
Messges
Model definition 'HyperVSite' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. 
Location: [Microsoft.OffAzure/stable/2022-10-27/migrate.json](https://github.com/Azure/azure-rest-api-specs/blob/81aece4a388def0c7cec404a915e0879b78df64f/specification/migrate/resource-manager/Microsoft.OffAzure/stable/2022-10-27/migrate.json#L12646)  
Model definition 'ImportSiteResource' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. 
Location: [Microsoft.OffAzure/stable/2022-10-27/migrate.json](https://github.com/Azure/azure-rest-api-specs/blob/81aece4a388def0c7cec404a915e0879b78df64f/specification/migrate/resource-manager/Microsoft.OffAzure/stable/2022-10-27/migrate.json#L13613)  
Model definition 'MasterSite' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. 
Location: [Microsoft.OffAzure/stable/2022-10-27/migrate.json](https://github.com/Azure/azure-rest-api-specs/blob/81aece4a388def0c7cec404a915e0879b78df64f/specification/migrate/resource-manager/Microsoft.OffAzure/stable/2022-10-27/migrate.json#L13883)  
Model definition 'ServerSiteResource' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. 
Location: [Microsoft.OffAzure/stable/2022-10-27/migrate.json](https://github.com/Azure/azure-rest-api-specs/blob/81aece4a388def0c7cec404a915e0879b78df64f/specification/migrate/resource-manager/Microsoft.OffAzure/stable/2022-10-27/migrate.json#L15271)  
Model definition 'V20200201DeleteImportMachinesJob' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. 
Location: [Microsoft.OffAzure/stable/2022-10-27/migrate.json](https://github.com/Azure/azure-rest-api-specs/blob/81aece4a388def0c7cec404a915e0879b78df64f/specification/migrate/resource-manager/Microsoft.OffAzure/stable/2022-10-27/migrate.json#L17321)  
Model definition 'VMwareSite' must have the properties 'name', 'id' and 'type' in its hierarchy and these properties must be marked as readonly. 
Location: [Microsoft.OffAzure/stable/2022-10-27/migrate.json](https://github.com/Azure/azure-rest-api-specs/blob/81aece4a388def0c7cec404a915e0879b78df64f/specification/migrate/resource-manager/Microsoft.OffAzure/stable/2022-10-27/migrate.json#L17679)
konrad-jamrozik commented 1 year ago

Another potential occurrence of this problem:

tejaswiMinnu commented 1 year ago

This is not false alarm. Please see this Teams channel here