search

Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
111 stars 171 forks source link

[Avocado] Validate that file paths are not too long #5931

Open konrad-jamrozik opened 1 year ago

konrad-jamrozik commented 1 year ago

(I didn't propose this. This was proposed by tianxchen-ms from the Shanghai team on Nov 30, 2022; I just converted it from draft)

issues: Spec PR validation broken for PoliCheck and CredScan jobs because of long path issues · Issue #3825 · Azure/azure-sdk-tools (github.com)

Feedback from wes:

we need to be a start enforcing that teams don't introduce paths that are too long. WE cannot depend on folks having longpath configured correctly on windows as that will be a blocker in a lot of cases.

For reference we have https://github.com/Azure/azure-sdk-tools/blob/main/eng/common/pipelines/templates/steps/verify-path-length.yml which we use in each of our SDK repos to enforce this.

Ruoxuan Wang [commented Oct 19]

From my perspective, I recommend to implement a validation rule in avocado. The reason is use verify-path-length.yml need to build another CI check. Since this function is quite small, so it's unnecessary to build addition check to do that.

konrad-jamrozik commented 9 months ago

Giving it low priority as it appears to be in purview of avocado, which is non-blocking check since August 2023.