Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
110 stars 175 forks source link

[Documentation] Guidance for AutoRest config README contents #6913

Open mikekistler opened 1 year ago

mikekistler commented 1 year ago

Many parts of our process depend on the readme.md file for a service in azure-rest-api-specs, but I am not aware of any documentation on the required structure or content of this file. When the "avocado" check for a PR fails because of incorrect readme content or structure, service teams are left to guess what should be done fix.

We need to clearly document the required structure and contents of readme.md and put this in an easily discoverable location.

cc: @ccbarragan @josefree @konrad-jamrozik

maririos commented 1 year ago

@mikekistler is this what you are looking for? https://eng.ms/docs/products/azure-developer-experience/design/api-specs/api-autorest

mikekistler commented 1 year ago

That looks promising but is missing important information, like how tagging works and how tagged releases should be structured. Avocado errors like MULTIPLE_API_VERSION and MISSING_APIS_IN_DEFAULT_TAG don't make any sense to service teams if they don't understand how tags work and are expected to be structured.

maririos commented 1 year ago

Who has that context to update the doc? @konrad-jamrozik is this you?

konrad-jamrozik commented 1 year ago

@mikekistler @maririos we have this work item:

(which is duplicated-and-partially-outdated here)

Which links to this:

But honestly I don't think I should take care of migrating it. This is about spec contents authoring and my area of responsibility is supporting the tooling for validating the specs, not the specs contents and conventions.

Relevant note: Swagger Avocado is no longer a required check to merge any specs PRs.

@weshaggard FYI