Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
109 stars 166 forks source link

Add permissions requirements for SDK repo when generating SDKS #7299

Open maririos opened 7 months ago

maririos commented 7 months ago

Before users start working on the SDKs (.NET management plane, and all languages in data plane), the app should have a check to ask people to have:

maririos commented 7 months ago

@jsquire the write permission is only once. Not per language repo, right?

jsquire commented 7 months ago

They'll need write permissions for every repo that they own code in - but we generally handle that via GitHub team membership so it should be a one-step process. @weshaggard would be able to confirm.

maririos commented 7 months ago

We could add a check in the Prerequisites section of the SDK Release apps to ensure the neccesary people have permissions:

image

Like another step that says Request access and have 2 checks: Text: Ensure every memeber of your team that is going to contribute to the Azure SDKs requests:

maririos commented 7 months ago

FYI @ladonnaq

maririos commented 3 months ago

After receiving more feedback that @catalinaperalta gathered from our service partner teams, we agreed to add this to each language step inside the "Generate SDK" task so the individual developer awknowledges they have permissions. Currently this will happen for every release

maririos commented 3 months ago

Added to March cycle