Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
109 stars 166 forks source link

docindex runs should be reporting warning, not success when there are packages that fail validation #7312

Open JimSuplizio opened 8 months ago

JimSuplizio commented 8 months ago

When trying to help onboard azureml-featurestore, the CSV was updated, the json was created and the python - docindex pipeline was green which leads one to believe that everything passed when, in fact, they didn't. I recognize that docs are "best effort" but if packages fail the Update Docs Onboarding for main branch step shouldn't be green, it should be orange. I believe we'd want to return SucceededWithIssues.

A secondary thing to do here would be to save up the errors and report them all at the end rather than having to mine 500+ lines of log looking for errors looking for interspersed warnings.

danieljurek commented 7 months ago

Make the step orange: https://learn.microsoft.com/en-us/azure/devops/pipelines/scripts/logging-commands?view=azure-devops&tabs=bash#complete-finish-timeline