search

Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
111 stars 176 forks source link

[Breaking Change] RemovedClientParameter validation may be incorrect #7384

Open heaths opened 10 months ago

heaths commented 10 months ago

In https://github.com/Azure/azure-rest-api-specs-pr/pull/16124/checks?check_run_id=19232503164, the validation said I removed the $.parameters["WeatherForecastResource.weatherForecastResourceName"] parameter, but it actually wasn't:

The TypeSpec emitter for swagger did this for reasons unknown, but it resolves to the same thing.

mikekistler commented 10 months ago

Dup of #5025

heaths commented 10 months ago

Almost a year old. If one plan was just to remove it, could we just do that as low-hanging fruit? I'd be happy to submit a PR. Anything to reduce false positives I feel necessary to investigate when reviewing. /cc @maririos

maririos commented 10 months ago

I lack context here. Which is the tool that is causing this?

heaths commented 10 months ago

Something in the validation pipeline. I can't be more specific than that, sorry.

mikekistler commented 10 months ago

This is the openapi-diff tool and the "breaking changes" scripts that are layered on top.