search

Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
114 stars 177 forks source link

.gitignore in specs repo should probably exclude all package*.json except in root #7588

Open heaths opened 9 months ago

heaths commented 9 months ago

Given the TypeSpec guidelines and design, it seems that the Azure/azure-rest-api-specs(-pr) repos' root .gitignore files should ignore all package.json and package-lock.json except in the root where we want to manage dependencies centrally. This will help teams avoid checking in their files by accident if, for example, migrating from an internal AzDO repo.

**/package.json
**/package-lock.json
!/package.json
!/package-lock.json
weidongxu-microsoft commented 9 months ago

Saw another PR trying to add .gitignore in subfolder, and similarly trying to ignore package.json https://github.com/Azure/azure-rest-api-specs/pull/27076/files

heaths commented 9 months ago

/cc @allenjzhang @lmazuel

konrad-jamrozik commented 9 months ago

@mikeharder assigning you as our TypeSpec person