Same-version API check (`Swagger BreakingChange`) should add `VersioningReviewRequired` instead of `BreakingChangeReviewRequired` when detecting issues on `preview` versions (as opposed to `GA`) (breaking changes confusion matrix)

Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.

MIT License

111 stars 176 forks source link

Same-version API check (`Swagger BreakingChange`) should add `VersioningReviewRequired` instead of `BreakingChangeReviewRequired` when detecting issues on `preview` versions (as opposed to `GA`) (breaking changes confusion matrix) #7724

Closed konrad-jamrozik closed 2 months ago

konrad-jamrozik commented 7 months ago

As in subject. Conversation in breaking_changes_confusion_matrix.pptx.

The goal is to make sure that the bottom left rectangle in the following diagram is VersioningReviewRequired instead of the currently deployed implementation of BreakingChangeReviewRequired:

Related file:

BreakingChangeRules.yml Related prerequisite work in-flight:
https://devdiv.visualstudio.com/DevDiv/_git/openapi-alps/pullrequest/528285

konrad-jamrozik commented 5 months ago

I think I might have actually completed this already - I nee to double check the source.

Update: not yet done

konrad-jamrozik commented 3 months ago

Pull Request 561778: Fix: add VersioningReviewRequired instead of BreakingChangeReviewRequired same-version preview scenario; svc 0.19.1; bump dependency on svc: ^0.18.0 -> ^0.19.0