Error retrieving PR information

Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.

MIT License

112 stars 172 forks source link

Error retrieving PR information #7790

Open maririos opened 6 months ago

maririos commented 6 months ago

Bug encountered by service partner related to the API readiness app of this release plan - https://aka.ms/sdk-release-planner?release-plan-id=3aa62ca9-00ba-ee11-a569-000d3a341bd5.

Error seen in the API readiness app

The API Stewardship Board has signed off but still not seen as approved in the API readines app.

praveenkuttappan commented 6 months ago

Issue has happened due to a bad URL as input for API pull request. URL ends with "\" for a pull request and that caused to have empty value as PR number. A URL to pull request always ends with PR number. We should add a validation to ensure that user input is correct.

maririos commented 6 months ago

The interesting thing is that we have validation, but it looked like the validation missed this case 😶

maririos commented 5 months ago

User is unblocked. For the remaining extra validation, I am moving the issue to backlog