Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
108 stars 166 forks source link

REST API Review scheduling tool should make onboarding meeting a prerequisite #8159

Open mikekistler opened 2 months ago

mikekistler commented 2 months ago

We had an API review meeting today where the service team used public TypeSpec instead of TypeSpec Azure Core. I asked if they had had an onboarding meeting with the SDK team, where they should have gotten clear direction on how to use TypeSpec, and they said they had not.

I think we should make the onboarding meeting a required prerequisite for a REST API review meeting, and the scheduling tool should verify this prereq before allowing a meeting to be scheduled.

maririos commented 2 months ago

Interesting. We already have a restriction where teams can't schedule a REST API meeting if they don't have a Release Plan. And in order to create a Release plan, they need to schedule an informational meeting. I went and look at today's meeting to understand what happened. It looks like the service team only selected a service and didn't add a product. If they don't add a product, they won't be able to have a release plan.

@ladonnaq what do you recommend we do here? An idea could be that for any team (independent of service or service and product) that doesn't add a release plan, automation can look to see if there is an Onboarding Work Item and see the status of the info meeting. If the tool couldn't find the work item, or the status of the Info meeting is not completed/scheduled then don't let them schedule the meeting

maririos commented 2 months ago

I talked offline with @ladonnaq and we are going to go ahead with the approach I proposed. Moving the issue to backlog