Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
112 stars 172 forks source link

[tsp-client] TypeError: tspLocation.additionalDirectories.map is not a function #8551

Closed Alancere closed 1 month ago

Alancere commented 2 months ago

exec: tsp-client update image

tsp-location.yaml from:

directory: specification/azurefleet/AzureFleet.Management
commit: 3cb1b51638616435470fc10ea00de92512186ece
repo: Azure/azure-rest-api-specs
additionalDirectories:
  - specification/mongocluster/DocumentDB.MongoCluster.Management
  - specification/apicenter/ApiCenter.Management

to ->

directory: specification/azurefleet/AzureFleet.Management
commit: 3cb1b51638616435470fc10ea00de92512186ece
repo: Azure/azure-rest-api-specs
additionalDirectories: specification/mongocluster/DocumentDB.MongoCluster.Management,specification/apicenter/ApiCenter.Management

position

Change the tsp-location.yaml additionalDirectories in the following location:

catalinaperalta commented 1 month ago

@Alancere can you provide more information, did the tool change the format of your tsp-location.yaml or did you do that manually?

Alancere commented 1 month ago

this my origin tsp-location.yaml content:

directory: specification/oracle/Oracle.Database
commit: 9a88bba565544d5907aaee7b10170fd770572904
repo: Azure/azure-rest-api-specs
additionalDirectories:
- specification/oracle/models

run tsp-client update --commit 9a88bba565544d5907aaee7b10170fd770572904 result: image

tsp-location.yaml was changed by the tool to the following

directory: specification/oracle/Oracle.Database
commit: 9a88bba565544d5907aaee7b10170fd770572904
repo: Azure/azure-rest-api-specs
additionalDirectories: specification/oracle/models
catalinaperalta commented 1 month ago

Investigating, looks like a bug in the tool

catalinaperalta commented 1 month ago

@Alancere I have a fix, should be able to release a new version of tsp-client early next week.

catalinaperalta commented 1 month ago

FYI this was fixed in the v0.9.4 release. Please update to that version and give it a try