search

Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
110 stars 172 forks source link

Missing SDK package work items for completed release plans (data plane) #8796

Open ladonnaq opened 1 month ago

ladonnaq commented 1 month ago

I am not consistently finding the SDK package work items related to the release plans or epic-product type in Azure Devops.

Here is a recent example:

Here is a query of all "Completed/Finished" Public Preview or GA release plans - https://dev.azure.com/azure-sdk/Release/_queries/query/?tempQueryId=f12549a7-1731-4862-a512-1836e431ead1.

maririos commented 1 month ago

Looking at this issue, there are multiple things happening:

  1. The cloud flow Automated create package work item is creating package work items, when they already exist. The logic is: a DevOps package appears, our sync jobs downloads the information into our SDK packages table. That information is then loaded into the UI so when the user selects the package and hits Next, we shouldn't create it again. Because of this we have decided to turn off the cloud flow in all instances.
  2. When the user selects a package and hits Next, we should link that package into the release plan and the product. We should have all this information already. In here, we need to make sure that the package work item doesn't have a parent already (if there is a parent we won't be able to link it to a Prodcut). If they have a parent and it is not the Product work item we expected, then we should overwrite.
ladonnaq commented 2 weeks ago

Looking at this issue, there are multiple things happening:

  1. The cloud flow Automated create package work item is creating package work items, when they already exist. The logic is: a DevOps package appears, our sync jobs downloads the information into our SDK packages table. That information is then loaded into the UI so when the user selects the package and hits Next, we shouldn't create it again. Because of this we have decided to turn off the cloud flow in all instances.
  2. When the user selects a package and hits Next, we should link that package into the release plan and the product. We should have all this information already. In here, we need to make sure that the package work item doesn't have a parent already (if there is a parent we won't be able to link it to a Prodcut). If they have a parent and it is not the Product work item we expected, then we should overwrite.

@maririos There are quite a few management plane release plans that are complete and I know the SDKs were released (b/c I saw the request email and the request issues are closed) but the package work items are not found with the release plan. Do you know why this is happening so we can resolve it? Does management plane need to do something specific to ensure that the package work items are created?

Here is another example - SDKs were released end of July but I do not see any of the SDK packages in ADO.

maririos commented 2 weeks ago

The fix I have been working on is for data plane. For management plane, do we have those work items created by any automation @praveenkuttappan ? if so, do you know how do they get linked to the product or the release planner work item?

ladonnaq commented 2 weeks ago

[like] LaDonna Quinn reacted to your message:

From: Mariana Rios Flores @.> Sent: Monday, August 26, 2024 11:48:54 PM To: Azure/azure-sdk-tools @.> Cc: Author @.>; Comment @.> Subject: Re: [Azure/azure-sdk-tools] Missing SDK package work items for completed release plans (Issue #8796)

The fix I have been working on is for data plane. For management plane, do we have those work items created by any automation @praveenkuttappanhttps://github.com/praveenkuttappan ? if so, do you know how do they get linked to the product or the release planner work item?

— Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-sdk-tools/issues/8796#issuecomment-2311302800 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQEFYOQYEV2C4OE3J5RKRH3ZTO5GRBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIZDGNJUGA3TINBSGOSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRUGI4DKMBUGU2DOMNENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTCNZQGU4TEMJYG2BKI5DZOBS2K2LTON2WLJLWMFWHKZNKGI2DKMZXGEZDGNRSQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRSGM2TIMBXGQ2DEM4CUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNBSHA2TANBVGQ3TDJ3UOJUWOZ3FOKTGG4TFMF2GK. You are receiving this email because you authored the thread.

Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

maririos commented 2 weeks ago

We talked more about this during stand up and it does seem that my change won't affect management plane. Praveen has some ideas on how we can improve this experience once he works on https://github.com/Azure/azure-sdk-tools/issues/8232.

To keep this issue in context, I am going to keep focusing on the data plane fix

ladonnaq commented 2 weeks ago

[like] LaDonna Quinn reacted to your message:

From: Mariana Rios Flores @.> Sent: Tuesday, August 27, 2024 9:06:16 PM To: Azure/azure-sdk-tools @.> Cc: Author @.>; Comment @.> Subject: Re: [Azure/azure-sdk-tools] Missing SDK package work items for completed release plans (Issue #8796)

We talked more about this during stand up and it does seem that my change won't affect management plane. Praveen has some ideas on how we can improve this experience once he works on #8232https://github.com/Azure/azure-sdk-tools/issues/8232.

To keep this issue in context, I am going to keep focusing on the data plane fix

— Reply to this email directly, view it on GitHubhttps://github.com/Azure/azure-sdk-tools/issues/8796#issuecomment-2313545673 or unsubscribehttps://github.com/notifications/unsubscribe-auth/AQEFYOQ4RWN555WP4GH3ZV3ZTTS4VBFKMF2HI4TJMJ2XIZLTSWBKK5TBNR2WLJDUOJ2WLJDOMFWWLO3UNBZGKYLEL5YGC4TUNFRWS4DBNZ2F6YLDORUXM2LUPGBKK5TBNR2WLJDUOJ2WLJDOMFWWLLTXMF2GG2C7MFRXI2LWNF2HTAVFOZQWY5LFUVUXG43VMWSG4YLNMWVXI2DSMVQWIX3UPFYGLAVFOZQWY5LFVIZDGNJUGA3TINBSGOSG4YLNMWUWQYLTL5WGCYTFNSBKK5TBNR2WLKRUGI4DKMBUGU2DOMNENZQW2ZNJNBQXGX3MMFRGK3FMON2WE2TFMN2F65DZOBS2YSLTON2WKQ3PNVWWK3TUUZ2G64DJMNZZJAVEOR4XAZNKOJSXA33TNF2G64TZUV3GC3DVMWUTCNZQGU4TEMJYG2BKI5DZOBS2K2LTON2WLJLWMFWHKZNKGI2DKMZXGEZDGNRSQKSHI6LQMWSWYYLCMVWKK5TBNR2WLKRSGM2TIMBXGQ2DEM4CUR2HS4DFUVWGCYTFNSSXMYLMOVS2UNBSHA2TANBVGQ3TDJ3UOJUWOZ3FOKTGG4TFMF2GK. You are receiving this email because you authored the thread.

Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.