Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
114 stars 180 forks source link

Figure out how the CODEOWNERS Linter is supposed to deal with changes to the baseline errors file #9103

Open JimSuplizio opened 1 month ago

JimSuplizio commented 1 month ago

This is in response to the following comment

The scenario here is that updates were made to the baseline errors file. What happened was a bunch of baseline errors were removed in a PR. PR processing generates a base branch baseline file against the base branch and some of the errors removed from the PR's baseline errors were in the baseline, which is used to do further filtering, allowed the PR through and didn't start failing until the nightly runs.

@weshaggard - I don't know how this is supposed to work if the CODEOWNERS_baseline_file.txt is updated as part of the PR.

In theory, the files changed in the PR could be inspected and we could skip the base branch generation if and only if, the CODEOWNERS_baseline_file.txt file is part of the PR. That would have the same problem in that the PR owner would be responsible for fixing whatever existing failures are in the nightly runs in order to get the PR through.

weshaggard commented 1 month ago

If they change the baseline file then I would suggest we don't use the baseline file from main at all. Yes if there are existing failures in main they will need to either fix or baseline them as part of the validation.