Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
114 stars 180 forks source link

Changes to Generate SDK task in management plane sdk app #9194

Open maririos opened 1 month ago

maririos commented 1 month ago
praveenkuttappan commented 4 days ago

@maririos @ladonnaq

UI changes in generate SDK to submit request to generate SDK for each language:

Image

Once request is submitted then UI will be changed to following and it will be updated with issue link as soon as issue is created.

Image

Labels will be further changed to show SDK generated status and an option to link PR will be visible. I will add those screens here once it is ready.

maririos commented 4 days ago

Looks good. Quesiton about the messages:

praveenkuttappan commented 4 days ago

Looks good. Question about the messages:

  • For both screens there is a big block of text. Once with gray shadow and the other blue shadow. It feels a little distracting because of how big they are. Would it look better to leave text only?
  • Was part of the requirements with Shanghai to ask them to send an email when the SDK is generated? or is the Release Planner going to do it? how? Should we instead just tell them to monitor that issue that will include the link to the PR where the generated SDK will be?
  • For the second UI consider removing the text "Next step will be...". if the person generating the SDK links the PR to the GH issue, can the Release Planner fetch that property and display it so we don't need to ask the user for it?
  1. I will update the UI to remove background color.
  2. Release planner is going to do it since we can automate the GitHub issue monitoring with a cloud flow. It will be more user friendly than asking user to monitor it especially if SDK generation is going to take days.
  3. I have also thought of doing it to make it easier. I will update the UI and also include the logic in cloud flow to parse GitHub comment for PR link and update it in release plan.