Azure / azure-sdk-tools

Tools repository leveraged by the Azure SDK team.
MIT License
114 stars 181 forks source link

[Scheduling Tool] Add label to GitHub issues for Azure SDK Reviews #9449

Open ronniegeraghty opened 1 day ago

ronniegeraghty commented 1 day ago

Problem:

Currently it is difficult for architects to search through issues from past Azure SDK Reviews to find notes or materials for reference. This is because issues for Azure SDK Reviews are opened in the Azure/azure-sdk and Azure/azure-sdk-pr repo, which contain many other types of issues that obscure the Azure SDK Review issues.

Proposed solution

When the scheduling tool creates an issue for an upcoming Azure SDK Review it should add a label to the issue. This way architects can filter the issue list for issues tagged with the label.

Suggestion for label

The Azure/azure-sdk repo currently has a SDKArchboard ReviewRequested label which we could adopt and add to the Azure/azure-sdk-pr repo. IMO the ideal label would be Azure SDK Review to match the type of meeting in the scheduling tool.

maririos commented 1 day ago

We can totally do this. We already have this functionality implemented in the API Review meetings. For example: https://github.com/Azure/azure-rest-api-specs/issues/31706

I like the Azure SDK Review label too. If you are good with that we can implement it

maririos commented 1 day ago

In all honesty, we haven't touched this code in a while, but because I know we already support it, it shouldn't take too long to figure it out :)

ronniegeraghty commented 20 hours ago

I like the Azure SDK Review label. It's created in the Azure/azure-sdk and Azure/azure-sdk-pr repos.

maririos commented 18 hours ago

This is from our test repo: https://github.com/azure-sdk/TestingForEngagementExperience-pr/issues/299

What do you think?

ronniegeraghty commented 17 hours ago

This is from our test repo: https://github.com/azure-sdk/TestingForEngagementExperience-pr/issues/299

What do you think?

Looks like I don't have permission to view that repo.

maririos commented 17 hours ago

This is from our test repo: azure-sdk/TestingForEngagementExperience-pr#299 What do you think?

Looks like I don't have permission to view that repo.

While I look at permissions: Image

ronniegeraghty commented 15 hours ago

Looks great!