search

Azure / azure-sdk

This is the Azure SDK parent repository and mostly contains documentation around guidelines and policies as well as the releases for the various languages supported by the Azure SDK.
http://azure.github.io/azure-sdk
MIT License
487 stars 297 forks source link

Board Review: Azure Load Testing (GA) #4952

Closed ninallam closed 1 month ago

ninallam commented 2 years ago

Thank you for submitting this review request. Thorough review of your client library ensures that your APIs are consistent with the guidelines and the consumers of your client library have a consistently good experience when using Azure.

The Architecture Board reviews Track 2 libraries only. If your library does not meet this requirement, please reach out to Architecture Board before creating the issue.

Please reference our review process guidelines to understand what is being asked for in the issue template.

To ensure consistency, all Tier-1 languages (C#, TypeScript, Java, Python) will generally be reviewed together. In expansive libraries, we will pair dynamic languages (Python, TypeScript) together, and strongly typed languages (C#, Java) together in separate meetings.

For Tier-2 languages (C, C++, Go, Android, iOS), the review will be on an as-needed basis.

Before submitting, ensure you adjust the title of the issue appropriately.

Note that the required material must be included before a meeting can be scheduled.

Contacts and Timeline

About the Service

About the client library

Artifacts required (per language)

Please read through “API Review” section here to understand how these artifacts are generated. It is critical that these artifacts are present and are in the right format. If not, the language architects cannot review them with the SDK Team’s API review tool.

.NET

Java

Python

TypeScript

For all other languages, send a request to the Architecture Board to discuss the best format on individual basis.

Thank you!

ninallam commented 2 years ago

@kyle-patterson The product team is based in India. Could you please help schedule this for the week of 11/7?

ronniegeraghty commented 2 years ago

Drafted

ronniegeraghty commented 2 years ago

Scheduled: Nov 7th 2022, 10:05AM - 12:00PM PST.

ronniegeraghty commented 2 years ago

Rescheduled to Nov 23rd from 9:05AM - 11AM PST.

mrinal2601 commented 1 year ago

Typescript PR - https://github.com/Azure/azure-sdk-for-js/pull/23842, Typescript API View - https://apiview.dev/Assemblies/Review/a95ad4657f904f6485d61ff4b6aed23b

Harshan01 commented 1 year ago

Java PR - https://github.com/Azure/azure-sdk-for-java/pull/31755/ Java API View - https://apiview.dev/Assemblies/Review/cd72e6a5038d48558489e0380645fecb Java Samples - https://github.com/Harshan01/azure-sdk-for-java/tree/loadtestservice-ga/sdk/loadtestservice/azure-developer-loadtesting/src/samples

ronniegeraghty commented 1 year ago

@ninallam Can you please add the other language API View's and Samples to this issue so the architects have time to review them before the session on the 23rd. Thank you.

NiveditJain commented 1 year ago

API View: C#: https://apiview.dev/Assemblies/Review/4200a804f382479bb4d2bb4a3323b8c7

Python: azure-developer-loadtesting - Created for PR #27274 - apiview.dev

PRs: C#: GA SDK for Azure LoadTesting by NiveditJain · Pull Request #32268 · Azure/azure-sdk-for-net (github.com)

Python: GA SDK Azure LoadTesting by NiveditJain · Pull Request #27274 · Azure/azure-sdk-for-python (github.com)

tg-msft commented 1 year ago

Recording (MS INTERNAL ONLY)

prativen commented 1 year ago

Updated API View: C#: https://apiview.dev/Assemblies/Review/4200a804f382479bb4d2bb4a3323b8c7

Java: https://apiview.dev/Assemblies/Review/cd72e6a5038d48558489e0380645fecb

Python: https://apiview.dev/Assemblies/Review/fc0755250d5e4c59b4b0a9e4d20dee53

JS RLC: https://apiview.dev/Assemblies/Review/528a55645b4746caa5618af352f9075e

Pull Requests: C#: https://github.com/Azure/azure-sdk-for-net/pull/32268

Java: https://github.com/Azure/azure-sdk-for-java/pull/31755

Python: https://github.com/Azure/azure-sdk-for-python/pull/27274 https://github.com/Azure/azure-sdk-for-python/pull/28417

JS RLC: https://github.com/Azure/azure-sdk-for-js/pull/23842

github-actions[bot] commented 1 month ago

Hi @ninallam, we deeply appreciate your input into this project. Regrettably, this issue has remained unresolved for over 2 years and inactive for 30 days, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.