search

Azure / azure-sdk

This is the Azure SDK parent repository and mostly contains documentation around guidelines and policies as well as the releases for the various languages supported by the Azure SDK.
http://azure.github.io/azure-sdk
MIT License
485 stars 296 forks source link

[IC3 ACS Resource Provider - Calling] SDK Review - Follow up #5043

Open azure-sdk opened 1 year ago

azure-sdk commented 1 year ago

New SDK Review meeting has been requested.

Service Name: IC3 ACS Resource Provider - Calling Review Created By: Jorge Garcia Hirota Review Date: 11/16/2022 2:00 PM PT

Reviewing a total of 3 features related to raw media:

1. Outgoing client-side RAW Video access in Windows

Architecture Diagram link: https://microsoft-my.sharepoint-df.com/:p:/p/yassirb/EZtCKSRZbj9GiW7bII2y058BzUg2meik8xHc-AeX7OUkHw?e=EyHtbp

APIView Links: https://apiview.dev/Assemblies/Review/9cbb119909d64dca816f7c8822944f78

Usage sample: https://apiview.dev/Assemblies/Samples/9cbb119909d64dca816f7c8822944f78

2. Incoming/Outgoing client-side RAW Audio access in Windows/Android

Android APIView: https://apiview.dev/Assemblies/Review/d290a65b305d4225983b6d5952c08373 Android Sample: https://apiview.dev/Assemblies/Samples/d290a65b305d4225983b6d5952c08373

Windows APIView: https://apiview.dev/Assemblies/Review/d2149c546f2f48aeb41176ec758928c0 Windows Sample: https://apiview.dev/Assemblies/Samples/d2149c546f2f48aeb41176ec758928c0

iOS APIView: https://apiview.dev/Assemblies/Review/ec0064fc9b52447cafe077c2b4aa5622?diffRevisionId=180f454fcfae4f748454a11b029ce554&diffOnly=False&revisionId=95d355d94982488f8d8d74af7167f9d0&doc=False

3. Remove dummy audio in client-side raw audio on iOS, Android, and Windows

iOS APIView: https://apiview.dev/Assemblies/Review/ec0064fc9b52447cafe077c2b4aa5622?diffRevisionId=146971b411a9492e90d9e9b87e73afe0&diffOnly=False&revisionId=180f454fcfae4f748454a11b029ce554&doc=False Windows APIView: Covered as part of raw audio in section 2 Android APIView: Covered as part of raw audio in section 2

4. Expose Participant Capabilities (ACS Web Calling SDK - Calling JS - Public preview):

API view: https://apiview.dev/Assemblies/Review/450ec180bb7d47dfa5f82fe33440073d?diffRevisionId=617a21dfa72d45309a3005fef7a4ca9f&diffOnly=False&revisionId=155281d16cf64e888f34c757993248ad&doc=False Design document [Champion Scenarios are added to this document]: ACS_CapabilityModel_DesignDocument.docx

Detailed meeting information and documents provided can be accessed here

JonathanGiles commented 1 year ago

I can only see JS and .NET APIViews in this issue - I'm just wanting to confirm that there are no plans to review iOS or Android libraries in this arch board review?

garchiro7 commented 1 year ago

Correct, only will be JS and .NET API's from two different teams.

gaobob-msft commented 1 year ago

@JonathanGiles we are going to combine 3 features into this one review, it will cover all iOS, Android, Windows.

garchiro7 commented 1 year ago

Team, we will use this meeting also to review a small feature:

Meeting updated by Elavarasi Duraipandian Chenthoorpan

Service Name: IC3 ACS Resource Provider - Calling Review Created By: Elavarasi Duraipandian Chenthoorpan Review Date: 11/10/2022 2:00 PM PT PR: [PR Link] Hero Scenarios Link: here Core Concepts Doc Link: Not Provided

Description: [ACS Calling SDK Web Team] [Public Preview] [Expose Participant Capabilities]

A new feature for Web, Android, iOS and Windows to allow developers to be able to get the capabilities of local participant in the communication setup.

Champion scenarios that briefly explain how developers will use your API: Client application uses ACS calling SDK to join a room call. Client application uses the getCapabilities api to fetch the capabilities of the local participant and paint the UI component according to what the participant is allowed to do in the call. Role of the local participant is changed when the call is in progress. Client application subscribed to the capability changed event receives the event on capability change. Client application uses the getCapabilities api to fetch the capabilities of the local participant and pain the UI component.

Detailed meeting information and documents provided can be accessed here

API view: https://apiview.dev/Assemblies/Review/450ec180bb7d47dfa5f82fe33440073d?diffRevisionId=4f7d531fd29d420289030cbd59f8d629&diffOnly=False&revisionId=33a9d403899b4fca8ae4b043536a59d6&doc=False#@skype/spool-sdk!CallFeatureFactory:interface Design document [Champion Scenarios are added to this document]: ACS_CapabilityModel_DesignDocument.docx

JonathanGiles commented 1 year ago

@gaobob-msft and @garchiro7 Your responses above are inconsistent. Can you please confirm which languages this review is for, and ensure we have a complete set of final APIViews you want us to look at for these languages? Thanks!

garchiro7 commented 1 year ago

Hi @JonathanGiles, sorry for the confusion. It will be 2 reviews happening tomorrow from calling team: 1) Service Name: IC3 ACS Resource Provider - Calling Native(priority)

2) Service Name: IC3 ACS Web Calling SDK - Calling JS (if we have enough time):

API view: https://apiview.dev/Assemblies/Review/450ec180bb7d47dfa5f82fe33440073d?diffRevisionId=4f7d531fd29d420289030cbd59f8d629&diffOnly=False&revisionId=c6274f4749534058bebaee5eac031060&doc=False Design document [Champion Scenarios are added to this document]: ACS_CapabilityModel_DesignDocument.docx

JonathanGiles commented 1 year ago

Can we please get a final, definitive set of links that should be reviewed for each? I'm still not seeing anything Android related yet.

DaybreakQuip commented 1 year ago

@JonathanGiles It's ready now. Had issues with decoupling other APIs from our features.

raosanat commented 1 year ago

Raw Audio for iOS

  1. Raw Audio Start/Stop has been re-designed by dropping dummy audio - v2. https://apiview.dev/Assemblies/Review/ec0064fc9b52447cafe077c2b4aa5622?diffRevisionId=146971b411a9492e90d9e9b87e73afe0&diffOnly=False&revisionId=180f454fcfae4f748454a11b029ce554&doc=False

  2. Raw Audio for iOS - v1. https://apiview.dev/Assemblies/Review/ec0064fc9b52447cafe077c2b4aa5622?diffRevisionId=180f454fcfae4f748454a11b029ce554&diffOnly=False&revisionId=95d355d94982488f8d8d74af7167f9d0&doc=False

cc: @tjprescott @DaybreakQuip

elavarasidc commented 1 year ago

Team, @tjprescott @DaybreakQuip @JonathanGiles @DaybreakQuip @raosanat @garchiro7, @jorge Please find below the capabilities API (targeted public preview) artifacts [api view, design doc with champion scenario below]. Who here will be helping with this JS language review today team?

Expose Participant Capabilities (ACS Web Calling SDK - Calling JS): API view: https://apiview.dev/Assemblies/Review/450ec180bb7d47dfa5f82fe33440073d?diffRevisionId=617a21dfa72d45309a3005fef7a4ca9f&diffOnly=False&revisionId=155281d16cf64e888f34c757993248ad&doc=False Design document [Champion Scenarios are added to this document]: ACS_CapabilityModel_DesignDocument.docx

Adding jeff.fisher@microsoft.com @xirzec for the JS review

tg-msft commented 1 year ago

Recording (MS INTERNAL ONLY)

xirzec commented 1 year ago

@bterlson and @joheredi can you take another look at the APIView?