search

Azure / azure-sdk

This is the Azure SDK parent repository and mostly contains documentation around guidelines and policies as well as the releases for the various languages supported by the Azure SDK.
http://azure.github.io/azure-sdk
MIT License
493 stars 300 forks source link

Azure DevEx Architecture Board: Review of IC3 ACS PSTN #5458

Open azure-sdk opened 1 year ago

azure-sdk commented 1 year ago

New SDK Review meeting has been requested.

Service Name: IC3 ACS PSTN Review Created By: Jorge Garcia Hirota Review Date: 2/21/2023 2:05 PM PT

Hero Scenarios Link: here Architecture Diagram Link: Not Provided Core Concepts Doc Link: Not Provided APIView Links: Javascript,

Description:

Customer wants to add trunk domains to the Direct routing configuration in Azure portal. To allow this, we've new property "domains" to SIP configuration and this property will be also visible through both "GET" and "PATCH" endpoint to show the trunk related domains. Additional property "enabled" is added to the "trunks" which indicates if specific trunk is used in direct routing flow when making a call. The scope of the work is only JavaScript SDK, as currently the only consumer is portal. After GA, we plan to make it available publicly.

Detailed meeting information and documents provided can be accessed here

azure-sdk commented 1 year ago

Meeting updated by Jorge Garcia Hirota

Service Name: IC3 ACS PSTN Review Created By: Jorge Garcia Hirota Review Date: 2/21/2023 2:05 PM PT

Hero Scenarios Link: here Architecture Diagram Link: Not Provided Core Concepts Doc Link: Not Provided APIView Links: Javascript,

Description: Customer wants to add trunk domains to the Direct routing configuration in Azure portal. To allow this, we've new property 'domains' to SIP configuration and this property will be also visible through both 'GET' and 'PATCH' endpoint to show the trunk related domains. Additional property 'enabled' is added to the 'trunks' which indicates if specific trunk is used in direct routing flow when making a call. The scope of the work is only JavaScript SDK, as currently the only consumer is portal. After GA, we plan to make it available publicly.

Detailed meeting information and documents provided can be accessed here

ronniegeraghty commented 1 year ago

@garchiro7 the API View for JS is missing a diff that is needed for the review. Also are there any other languages to review? The Arch Board team wants to review changes for all languages in one meeting.

garchiro7 commented 1 year ago

No, this is only for JS.
Let me ask for the diff version and I'll back to you

ronniegeraghty commented 1 year ago

No, this is only for JS.

So is this a feature only being implemented in JS or it's already implemented in the other languages?

garchiro7 commented 1 year ago

Only JS at the moment.

ronniegeraghty commented 1 year ago

What I'm hearing is that eventually the features will come to the other languages. The Arch Board really wants to move away from doing reviews for one language first then the other languages later. They would much prefer to review all the languages together to make sure there are no un-needed inconsistencies between the languages. Is there a reason to get this approved in JS before the other languages?

garchiro7 commented 1 year ago

good question, let me ask, @nostojicMs ; do you have more insights regarding Ronnie questions?

nostojicMs commented 1 year ago

Hello, I updated the api view so it should show diff now. Let me know if this is ok. Regarding other languages, this feature will be available later in other languages, but currently we worked only on JS because of GA deadline we have which is end of March. For GA we are only providing this functionality via Azure portal, which is why we have only the JS SDK. cc @ronniegeraghty @garchiro7

ronniegeraghty commented 1 year ago

Let me speak with the architect team to see if we can make an exception because of the GA deadline. In the future it is highly preferable that all languages be reviewed at the same time so we can reduce unnecessary inconsistencies between languages and so the architects don't have to refer back to a review that happened month before.