Azure / azure-sdk

This is the Azure SDK parent repository and mostly contains documentation around guidelines and policies as well as the releases for the various languages supported by the Azure SDK.
http://azure.github.io/azure-sdk
MIT License
482 stars 297 forks source link

Azure DevEx Architecture Board: Introduction of ACS Auth Service #5513

Open azure-sdk opened 1 year ago

azure-sdk commented 1 year ago

New SDK Review meeting has been requested.

Service Name: ACS Auth Service Review Created By: Jorge Garcia Hirota Review Date: 3/2/2023 2:05 PM PT

Hero Scenarios Link: here Architecture Diagram Link: here Core Concepts Doc Link: Not Provided APIView Links: Javascript,

Description: The proposed change is to add support for Teams bots in the Common library in a generic way that shall be used going forward for any bot flows in Teams. As many critical call flows are driven via bots (CQ , Voicemail, Recording, Captions, etc.) and a Calling team needs to define a way to support a bot identifier different from a user identifier.

Detailed meeting information and documents provided can be accessed here

Champion scenarios:

// Get a bot account from Microsoft Graph
const options = {
   authProvider,
};

const client = Client.init(options);

let users = await client.api('/users')
   .filter(filterConditions)
   .select('displayName,id')
   .get();

// Response:

HTTP/1.1 200 OK
Content-type: application/json
{
  "value": [
    {
      "displayName": "Voice Application Bot",
      "id": "87d349ed-44d7-43e1-9a83-5f2406dee5bd"
    }
  ]
}
// Create Microsoft Bot Identifier from bot ID
const bot = MicrosoftBotIdentifier(id: "87d349ed-44d7-43e1-9a83-5f2406dee5bd", cloud: "dod", isResourceAccountConfigured: false);

// Make a call made to the Microsoft bot
call = callAgent.startTeamsUserCall([{ id: bot }])
ronniegeraghty commented 1 year ago

Hi @garchiro7, The architects want to understand how this will be supported in the other languages as well. Would be best to review all languages at the same time. Are the other languages able to be reviewed?

garchiro7 commented 1 year ago

@petrsvihlik , @ostoliarova-msft . Can you provide more insights/availability of other language SDKs?

ostoliarova-msft commented 1 year ago

@ronniegeraghty, @garchiro7 our team is currently working on the implementations in .NET, Python, Java and mobile platforms. these should be ready in the upcoming weeks. Once we have the PRs pass our team's review, I'll update the description here and include the links.

azure-sdk commented 1 year ago

Meeting updated by Jonathan Cardenas

Service Name: ACS Auth Service Review Created By: Jorge Garcia Hirota Review Date: March 2, 2023 10:00 AM PT

Hero Scenarios Link: here Architecture Diagram Link: here Core Concepts Doc Link: Not Provided APIView Links: Javascript,

Description: The proposed change is to add support for Teams bots in the Common library in a generic way that shall be used going forward for any bot flows in Teams. As many critical call flows are driven via bots (CQ , Voicemail, Recording, Captions, etc.) and a Calling team needs to define a way to support a bot identifier different from a user identifier.

Detailed meeting information and documents provided can be accessed here

ronniegeraghty commented 1 year ago

@ostoliarova-msft, Wanted to ping again about the addition of the other languages' API View links?

ostoliarova-msft commented 1 year ago

@ronniegeraghty .NET API view: https://apiview.dev/Assemblies/Review/22842eeaf5504bdfa3d305d7e049e477?diffRevisionId=00dd36d3ed094021922001f2db7b3262&diffOnly=False&revisionId=da45ddeca97b43aba39d9b16427dfdba&doc=False PR: https://github.com/Azure/azure-sdk-for-net/pull/34032

Python API view: https://apiview.dev/Assemblies/Review/bb690e01f4714b54a439b3670e409dcc?diffRevisionId=20cb6eb4934b4daea1d89c5c07c66235&diffOnly=False&revisionId=604669a939ab47eca8543a384b3610fb&doc=False https://apiview.dev/Assemblies/Review/88a652ca2dcd4fb4acca6b6028070ebf?diffRevisionId=3b72c77b4e024a1e861b970dd888d052&diffOnly=False&revisionId=48714636402848ec9f95035a7e1fdf04&doc=False PR: https://github.com/Azure/azure-sdk-for-python/pull/28910

Java API view: https://apiview.dev/Assemblies/Review/d70b841f485d4854870aa13688b23d2e?diffRevisionId=51937aef84e74c89b6bc685432544205&diffOnly=False&revisionId=527402c5099b4112b0559349a22548e3&doc=False PR: https://github.com/Azure/azure-sdk-for-java/pull/33634

ostoliarova-msft commented 1 year ago

@ronniegeraghty also adding links to mobile platforms Android API view: azure-communication-common PR: https://github.com/Azure/azure-sdk-for-android/pull/1307 iOS API view: AzureCommunicationCommon (version 1.3.0) PR: https://github.com/Azure/azure-sdk-for-ios/pull/1468