search

Azure / azure-sdk

This is the Azure SDK parent repository and mostly contains documentation around guidelines and policies as well as the releases for the various languages supported by the Azure SDK.
http://azure.github.io/azure-sdk
MIT License
472 stars 293 forks source link

Azure SDK Review of Azure.Core - [Azure SDK] #5986

Open azure-sdk opened 1 year ago

azure-sdk commented 1 year ago

New SDK Review meeting has been requested.

Service Name: Azure SDK Review Created By: Anne Loomis Thompson Review Date: 05/02/2023 02:05 PM PT

Hero Scenarios Link: Not Provided Architecture Diagram Link: Not Provided Core Concepts Doc Link: Not Provided APIView Links:

Description: Combined session for Azure.Core and Event Grid System Events for May release

Detailed meeting information and documents provided can be accessed here

JoshLove-msft commented 1 year ago

.NET Event Grid events - https://apiview.dev/Assemblies/Review/8b3a745cdd6f46a0922719b0431e3d9f/9eaf4fd5c5b946b3ac6065aac9d227a1?diffRevisionId=efd18952350941c7b2819c4fd7fb80a7&doc=False&diffOnly=True

annelo-msft commented 1 year ago

Azure.Core:

billwert commented 1 year ago

Java Event Grid Events - https://apiview.dev/Assemblies/Review/5e8f73347cdb468bb427116a114b7c87/e9ee1f67f17f4fada5261218c9cd1208?diffRevisionId=f550efc97e424933a374b435787dcec8&doc=False&diffOnly=True

JoshLove-msft commented 1 year ago

Response on RequestFailedException Api View - https://apiview.dev/Assemblies/Review/73b41ac08d194044a311def8eda66152/bcf55fa93bda4f87b9d4fa2d438783fb?diffRevisionId=f713231db5624bf2bbb6d3cd6b887eb6&doc=False&diffOnly=True

l0lawrence commented 1 year ago

Python Event Grid Events: https://apiview.dev/Assemblies/Review/73a1b661029444fa9a09e82db1a8aea2?diffRevisionId=210fe6ce4039415f80aae4bfe87cd45b&diffOnly=False&revisionId=784eb9f83ac8430c8689f6594cebb146&doc=False

sarangan12 commented 1 year ago

JS APIView: https://apiview.dev/Assemblies/Review/05f998594f194b9d9d7aa7030b97dbcf?diffRevisionId=20de95415c504ea79c1558fd546351cc&diffOnly=False&revisionId=21f3df795a1f4efe9c083402075894e2&doc=False

ahsonkhan commented 1 year ago

Azure.Core:

@annelo-msft, what did you have to do to enable casting of the dynamic object to any CLR POCO type? Was there a particular interface you had to implement to make that work (+ reflection), because the only "cast" operators I see are to the basic .NET primitive types: https://github.com/Azure/azure-sdk-for-net/blob/a071c587530d5b49d12a57f697a287774086c364/sdk/core/Azure.Core/samples/DynamicContent.md#cast-to-a-poco-type https://github.com/Azure/azure-sdk-for-net/blob/e07f1f6c627f1aebc139d9c7f83ec8840096eca1/sdk/core/Azure.Core/api/Azure.Core.netstandard2.0.cs#L59-L69

annelo-msft commented 1 year ago

@ahsonkhan, DynamicData implements IDynamicMetaObjectProvider. The DLR invokes BindConvert() when a cast operator is used, and in DynamicData, we call through to the ConvertTo<T>() method for POCOs.

ahsonkhan commented 1 year ago

Edit: Left comment on APIView instead.