Azure / azure-sdk

This is the Azure SDK parent repository and mostly contains documentation around guidelines and policies as well as the releases for the various languages supported by the Azure SDK.
http://azure.github.io/azure-sdk
MIT License
482 stars 296 forks source link

Board Review: Management Plane Namespace Review Azure Cosmos DB for PostgreSQL #6002

Closed mozansaka closed 1 year ago

mozansaka commented 1 year ago

Thank you for submitting this review request. Thorough review of your management library namespaces ensures that your library names are consistent with the guidelines and the consumers of your management library have a consistently good experience when using Azure.

To ensure consistency, all language library names will generally be reviewed together.

Before submitting, ensure you adjust the title of the issue appropriately.

Note that the required material must be included before a meeting can be scheduled.

Contacts and Timeline

About the Service (required)

Namespace Proposals (required per language)

We relatively recently rebranded our service from "Azure Database for PostgreSQL Hyperscale" into "Azure Cosmos DB for PostgreSQL"; practically became one of the Cosmos DB APIs from customer perspective. However, we are still using our previous resource provider Microsoft.DBforPostgreSQL; sharing it with Azure Database for PostgreSQL - Flexible Server and Single Server services. More detail: https://learn.microsoft.com/en-us/azure/postgresql/hyperscale/moved?tabs=direct

That's why, we decided to focus on our new service name with the namespaces rather than using resource provider names.

Thank you!

ArthurMa1978 commented 1 year ago

For .Net, the name space shoule be Azure.ResourceManager.CosmosDBForPostgreSQL

ronniegeraghty commented 1 year ago

I made the name change @ArthurMa1978 suggested for .NET. Now moving the approval process into phase 2. The names will be presented to the rest of the Azure SDK architect team. They will have until the end of business on May 11th to state any comments or objections they have with the proposed names.

m-nash commented 1 year ago

@ArthurMa1978 is there any reason we don't go with Azure.ResourceManager.CosmosDB.PostgresSQL? @KrzysztofCwalina do you have an opinion on this one?

tadelesh commented 1 year ago

Go will use sdk/resourcemanager/cosmosforpostgresql/armcosmosforpostgresql.

ronniegeraghty commented 1 year ago

The names in the description of this issue have been approved as they show in the description in it's most recent update.