search

Azure / azure-service-bus-dotnet

☁️ .NET Standard client library for Azure Service Bus
https://azure.microsoft.com/services/service-bus
Other
235 stars 120 forks source link

Fix NamespaceClient.GetNamespaceInfoAsync() #638

Closed SeanFeldman closed 5 years ago

SeanFeldman commented 5 years ago

Fixes #637

SeanFeldman commented 5 years ago

This will need to be a minor release as we're adding to the public API of an existing type NamespaceType.

SeanFeldman commented 5 years ago

@nemakam should we deprecate NamespaceType.ServiceBus or leave it as-is?

SeanFeldman commented 5 years ago

I can live with that, but we'll need to change that in v4.

Sean Feldman

On Sat., Jan. 26, 2019, 00:00 Neeraj Makam <notifications@github.com wrote:

@nemakam requested changes on this pull request.

In test/Microsoft.Azure.ServiceBus.UnitTests/API/ApiApprovals.ApproveAzureServiceBus.approved.txt https://github.com/Azure/azure-service-bus-dotnet/pull/638#discussion_r251162995 :

@@ -730,6 +730,7 @@ namespace Microsoft.Azure.ServiceBus.Management public enum NamespaceType { ServiceBus = 0,

  • Messaging = 1,

This is actually not true. Problem is that ServiceBus is called Messaging in service side. Didnt realize when I renamed the enum. The correct thing is to rename ServiceBus to Messaging. But that is going to break things. So the alternative that I can think of is to manually handle the deserialization and if it is Messaging, then convert it to ServiceBus. :(

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/Azure/azure-service-bus-dotnet/pull/638#pullrequestreview-196745522, or mute the thread https://github.com/notifications/unsubscribe-auth/ABP7tk_sjm3RvVJMmGrmodcrrHfX26Dkks5vG4x9gaJpZM4aQGsU .

SeanFeldman commented 5 years ago

@nemakam updated

SeanFeldman commented 5 years ago

@nemakam could you please raise an issue for 4.0.0 milestone to address https://github.com/Azure/azure-service-bus-dotnet/pull/638/commits/f10cae959227ab8d28e9fe5877b968b789a1df0e#diff-4f0427b57425e52bf6ea1d62facac6b9R69? Thanks.

SeanFeldman commented 5 years ago

@nemakam please review

SeanFeldman commented 5 years ago

@nemakam who could review this?

nemakam commented 5 years ago

I guess we could just leave it as-is.

In reply to: 457061141 [](ancestors = 457061141)