Session receiver stops processing next sessions - Githubissues

Azure / azure-service-bus-dotnet

☁️ .NET Standard client library for Azure Service Bus

https://azure.microsoft.com/services/service-bus

Other

235 stars 120 forks source link

Session receiver stops processing next sessions #687

Open petrformanek opened 5 years ago

petrformanek commented 5 years ago

Actual Behavior

I have simple session enabled subscription consumed by following code snippet
Processing of messages takes longer than MaxAutoRenewDuration
After processing of the first message the pump gets stuck and no other messages are processed

Expected Behavior

Message processing will continue with another session

Discovered bug

From debugging it looks like a bug in method SessionReceivePump.MessagePumpTaskAsync in finally block.
When calling CancelAndDisposeCancellationTokenSource(renewLockCancellationTokenSource); there is a ObjectDisposedException and because of that this.maxConcurrentSessionsSemaphoreSlim.Release(); is not called and pump gets stuck while waiting on semaphore release.

Versions

OS platform and version: Windows 10
.NET Version: .NET Core 2.1
NuGet package version or commit ID: both 3.2 and 3.4

Might be related to issue #595.

axisc commented 5 years ago

@petrformanek thanks for reporting this. We confirmed that this is a bug.

We'll add this to the backlog, but alternatively feel free to submit a PR and we can review and approve.

petrformanek commented 5 years ago

Hi guys, any ETA for the fix?