search

Azure / azure-service-operator

Azure Service Operator allows you to create Azure resources using kubectl
https://azure.github.io/azure-service-operator/
MIT License
793 stars 204 forks source link

Need to handle additionalProperties in JSON serialization #1462

Open Porges opened 4 years ago

Porges commented 4 years ago

When serializing an ObjectType that has an additionalProperties field to JSON, we need to flatten the properties inside it into the “parent” type. I’m not sure this is even possible with the built-in JSON Go serialization library, so we might need to look elsewhere.

matthchr commented 2 years ago

Where does this come up?

Porges commented 2 years ago

Where does this come up?

Mostly services that have a “map but with some well-known entries” pattern.

super-harsh commented 2 years ago

We're still interested in doing this.

matthchr commented 1 year ago

Have we actually already done this? We should double-check

theunrepentantgeek commented 1 year ago

We haven't done this, but would be good to do.

matthchr commented 1 year ago

No change from above

matthchr commented 8 months ago

Mostly services that have a “map but with some well-known entries” pattern.

Wondering if there's a way to know which services these are? Maybe we should take a look and get an understanding of how large the problem is to understand how important this is to fix?

matthchr commented 2 months ago

Haven't had time to do the above checking yet, but it also doesn't seem to be a major problem for users currently.