Azure / azure-service-operator

Azure Service Operator allows you to create Azure resources using kubectl
https://azure.github.io/azure-service-operator/
MIT License
716 stars 194 forks source link

Bug: BackupVaultBackupInstance resource comes to ready state inside cluster even when the protection state is "configuring protection" #3985

Closed mayankagg9722 closed 2 weeks ago

mayankagg9722 commented 4 months ago

ASO V2 - v2.7.0

Resource Provider: Microsoft.DataProtection

Describe the bug BackupVaultBackupInstance resource comes to ready state inside cluster even when the protection state is "configuring protection" in Azure. Also when protection state changes to "protection configured", the YAML of the resource is not refreshed and took long time before it shows the right updated details that is shown in Azure portal. This might cause confusion for the customers.

To Reproduce Steps to reproduce the behavior: 1) Post performing all the prerequisutes create the BackupVaultBackupInstance resource in the cluster using ASO. 2) BackupVaultBackupInstance will come to ready state immediately, but the protection state is configuring protection.

Expected behavior BackupVaultBackupInstance resource should be in waiting state (or show some message along with ready state) until the protection state changes from configuring protection to protection configured. Also, the refresh/fetch rate should be immediate so that misinformation is not communicated to customers from Azure portal and in ASO resource YAML.

Screenshots image image image image

mayankagg9722 commented 4 months ago

Discussed with @theunrepentantgeek offline.

theunrepentantgeek commented 4 months ago

We agree that the resource shouldn't show Ready true until protection is fully configured; we'll look into updating this. (Reference links included in the original Conditions ADR.)

super-harsh commented 2 weeks ago

Fixed in #4180