Turns out that our test case ordering wasn't deterministic.
When calling NewTestFileDefinition() to generate a _test.go file, the slice of TypeDefinition passed in comes directly from a map (via maps.Values()) , and therefore has non-deterministic ordering.
Special notes for your reviewer:
I'm surprised we didn't observe this before, I'm guessing there's a change in go 1.22.2 as I just updated to that version (was running go 1.22.1 previously.
What this PR does / why we need it:
Turns out that our test case ordering wasn't deterministic.
When calling
NewTestFileDefinition()to generate a_test.gofile, the slice ofTypeDefinitionpassed in comes directly from a map (viamaps.Values()) , and therefore has non-deterministic ordering.Special notes for your reviewer:
I'm surprised we didn't observe this before, I'm guessing there's a change in
go 1.22.2as I just updated to that version (was runninggo 1.22.1previously.How does this PR make you feel: