Azure / azure-service-operator

Azure Service Operator allows you to create Azure resources using kubectl
https://azure.github.io/azure-service-operator/
MIT License
702 stars 188 forks source link

Remove top level of indentation from type structure reports #4069

Closed theunrepentantgeek closed 3 weeks ago

theunrepentantgeek commented 4 weeks ago

What this PR does / why we need it:

Removes the top level of indentation from our structure reports, effectively moving type-names to the left margin.

Moving each type to the top level means reduced churn (smaller diffs) when a new type is added to a file.

Old report:

github.com/Azure/azure-service-operator/testing/person/v20200101
└── Relationship: Object (2 properties)
    ├── FirstParty: *Object (4 properties)
    │   ├── FamilyName: string
    │   ├── FullName: string
    │   ├── KnownAs: string
    │   └── Parent: *Person
    └── SecondParty: *Object (4 properties)
        ├── FamilyName: string
        ├── FullName: string
        ├── KnownAs: string
        └── Parent: *Person

New report:

github.com/Azure/azure-service-operator/testing/person/v20200101
----------------------------------------------------------------
Relationship: Object (2 properties)
├── FirstParty: *Object (4 properties)
│   ├── FamilyName: string
│   ├── FullName: string
│   ├── KnownAs: string
│   └── Parent: *Person
└── SecondParty: *Object (4 properties)
    ├── FamilyName: string
    ├── FullName: string
    ├── KnownAs: string
    └── Parent: *Person

Special notes for your reviewer:

How does this PR make you feel: gif

matthchr commented 3 weeks ago

Some failing tests that need to be fixed?