Azure / azure-service-operator

Azure Service Operator allows you to create Azure resources using kubectl

https://azure.github.io/azure-service-operator/

MIT License

702 stars 188 forks source link

Batch Job - Pre update checker should honor toloration/affinity #4114

Closed tikicoder closed 3 days ago

tikicoder commented 2 weeks ago

Describe the current behavior There is not tolerations or affinity applied to the batch job. v2/charts/azure-service-operator/templates/pre-release-hook/batch_v1_job_pre-upgrade-checker.yaml

Describe the improvement I would presume if I have created tolerations/node affinity that it would use that as part of its creation to ensure its not interfering with other node pools

theunrepentantgeek commented 1 week ago

Possibly related to #3436

tikicoder commented 1 week ago

@theunrepentantgeek Thanks, that does look to be the cause of my issue

3436

I will look to monitor that milestone and hope it is included.

matthchr commented 3 days ago

Going to go ahead and close this in favor of #3436 - which should ideally be happening in 2.9.0