search

Azure / azure-service-operator

Azure Service Operator allows you to create Azure resources using kubectl
https://azure.github.io/azure-service-operator/
MIT License
702 stars 188 forks source link

Fix pre-release-test task target #4128

Closed super-harsh closed 1 week ago

super-harsh commented 1 week ago

What this PR does / why we need it:

This PR fixes the TaskFile's controller:test-upgrade-apply-prerelease-chart target to replace the old target controller:gen-helm-manifest to controller:package-helm-manifest

Also, fixes create-kind-wi-storage.sh to set --allow-blob-public-access==false for StorageAccount creation.

matthchr commented 1 week ago

Also, fixes create-kind-wi-storage.sh to set --allow-blob-public-access==false for StorageAccount creation.

Was there an error someplace? IIRC this is the default, it shouldn't need to be specified explicitly?

super-harsh commented 1 week ago

@matthchr - allow-blob-public-access is blocked by the policy from going forward in test tenant and is set to True by default.

super-harsh commented 1 week ago

actually, default is True for versions prior to 2023-01-01. What version does az pick up by default? any idea? :-?

matthchr commented 1 week ago

It should pick the latest API (depending on version of CLI). The docker container at least is using a new-ish version of the CLI so should have this as the default, but being explicit doesn't hurt.