search

Azure / azure-service-operator

Azure Service Operator allows you to create Azure resources using kubectl
https://azure.github.io/azure-service-operator/
MIT License
702 stars 188 forks source link

PostReconcileCheck not running on BackupVaultBackupInstance resource #4135

Open mayankagg9722 opened 1 week ago

mayankagg9722 commented 1 week ago

Version

ASO v2.7.0

Describe the bug Seeing a regressed behavior where there is no post reconciliation and BeginSyncBackupInstance called on the BackupVaultsBackupInstance even though it was failed user error and in protection error state (our condition in post reconciliation)

https://github.com/mayankagg9722/azure-service-operator/blob/e66c3fd05fc6af0a4efb0551b858d01eee2c7376/v2/api/dataprotection/customizations/backup_vaults_backup_instance_extensions.go#L98

To Reproduce Post performing all the prerequisutes, create the BackupVaultBackupInstance resource in the cluster using ASO. Use this Yaml: bie2etest.txt

Expected behavior BeginSyncBackupInstance should be called which is there in the reconciliation flow.

https://github.com/mayankagg9722/azure-service-operator/blob/e66c3fd05fc6af0a4efb0551b858d01eee2c7376/v2/api/dataprotection/customizations/backup_vaults_backup_instance_extensions.go#L98

Screenshots Activity logs portal:

image

Backup Instance:

image image

ASO Logs: image

asologs.txt asologs1.txt

Backup Instance YAML in Cluster:

image

mayankagg9722 commented 1 week ago

@theunrepentantgeek @super-harsh Please help me to debug this further.

matthchr commented 3 days ago

We'll take a look at this

mayankagg9722 commented 3 days ago

I have discussed this with @super-harsh and he figured out that this commit by him caused this breaking change: https://github.com/Azure/azure-service-operator/pull/3953/files.

We need to revert this checkin.