Closed matthchr closed 2 months ago
We also might want to look at adding some verbose logging to make it more obvious if/when throttling is kicking in. Or possibly there already is some in controller-runtime, which if there is we should document how to get at it.
Describe the current behavior We self-throttle to avoid ARM throttling: https://github.com/Azure/azure-service-operator/blob/807a2bb52d0cbc9f4db424fb0fc30ca2bcbacda9/v2/internal/reconcilers/generic/generic_reconciler.go#L278-L295
Describe the improvement ARM has since changed how they throttle, and we have moved to support multiple identities/multiple subscriptions, which means that this simple bucket-based throttling is no-longer sufficient.
We should either remove the self-throttling entirely, OR make it larger and possibly configurable. I tend towards removing it given that: