Fix bug where 'none' crd-management mode blocked pod start

Azure / azure-service-operator

Azure Service Operator allows you to create Azure resources using kubectl

https://azure.github.io/azure-service-operator/

MIT License

738 stars 194 forks source link

Fix bug where 'none' crd-management mode blocked pod start #4151

Closed matthchr closed 2 months ago

matthchr commented 3 months ago

This happened because in 'none' mode goalCRDs was the set of installed CRDs, but we built an exclusion list from that set and used it to filter the set of known storage types from the scheme. When count(existing) = 5 and count(scheme)=200, the most you can possibly filter from the scheme with an exclusion list is 5 which leaves 195 CRDs being mistakenly installed.

Fixes #4146.

If applicable:

[ ] this PR contains documentation
[x] this PR contains tests
[ ] this PR contains YAML Samples

matthchr commented 3 months ago

/ok-to-test sha=a483c7f