search

Azure / azure-spatial-anchors-samples

Azure Spatial Anchors sample code
Other
293 stars 139 forks source link

UserFeedback for Maximum limit during creating an Anchor #338

Closed nikhilsawlani closed 2 years ago

nikhilsawlani commented 2 years ago

Hi,

I know there is class UserFeedback which shows RecommendedForCreateProgress here in doc, but I wanted to check if we have a MaximumForCreateProgress' method? as in our case users sometime croses the limit of RecommendedForCreateProgress and when they save an Anchor the session gets Reset (dumping all captured features) and users have to start again.

So if we have MaximumForCreateProgress method we can show users upfront how max they can go while creating an anchor instead they saving it and then returning that it is out of limit

mrwellmann commented 2 years ago

As far as in know there is currently no 'MaximumForCreateProgress' we are using internally 2 as maximum value. If you haven not seen this, here are some more insight on this topic https://github.com/Azure/azure-spatial-anchors-samples/issues/268

nikhilsawlani commented 2 years ago

As mentioned in #268 there is no hard limit on the amount of environmental data that is uploaded to the service during anchor creation. but that's not the case here it seems as if users capture larger space it doesn't create an anchor. there should some indicator to give users hard limit feedback

nikhilsawlani commented 2 years ago

Hi @pamistel could be please tell me ifs possible to find how much environment an anchor can capture.

Varnauld commented 2 years ago

Hello, There is no correlation between a session resetting and the system reaching any maximum limit for environment data. As part of saving the anchor, the SDK uploads some environment data that it has been collecting in the background. The "recommended for create progress" and "ready for create progress" values reflect if enough data has been collected for successfully saving an anchor and saturate at 1.0. Even after they saturate the system keeps collecting data as the device scans the space further. We do not currently surface through an API if a limit has been reached for saving an anchor. If this is a feature you believe would be valuable, could you submit the idea here please (we review and consider these for future iterations). Thank you!

nikhilsawlani commented 2 years ago

Thanks, I have submitted the idea

Varnauld commented 2 years ago

Thank you @nikhilsawlani !