Fixes for standard and enterprise deployment issues

Azure / azure-spring-apps-landing-zone-accelerator

The Azure Spring Apps landing zone accelerator is an open-source collection of architectural guidance and reference implementation to accelerate deployment of Azure Spring Apps at scale.

MIT License

80 stars 76 forks source link

Fixes for standard and enterprise deployment issues #204

Closed jeffpaineMS closed 12 months ago

jeffpaineMS commented 1 year ago

Resolves and Issue where terraform would crash with latest version, pins to 1.5.7 Resolves issue with GitHub ASA deploy task causing deployment to fail due to not having access to log stream, now uses az sping app deploy CLI Standard GitHub action workflow will now allow destroy steps to run if app deployments fail

luisfeliz79 commented 1 year ago

There may be an issue with the Standard-Petclinic sample deployment where , the az spring deploy step for api-gateway fails. However, none of the files modified in this PR would have affected by this, meaning that the issue may have been there from before. I think we should move forward with this particular PR and create a separate issue for the problem I mentioned.

luisfeliz79 commented 12 months ago

The issues with "the az spring deploy step for api-gateway fails" have been resolved!

kriation commented 12 months ago

@luisfeliz79, ready to merge?