search

Azure / azure-spring-apps-landing-zone-accelerator

The Azure Spring Apps landing zone accelerator is an open-source collection of architectural guidance and reference implementation to accelerate deployment of Azure Spring Apps at scale.
MIT License
80 stars 76 forks source link

Terraform should accept jumphost vm admin name #51

Closed selvasingh closed 3 years ago

selvasingh commented 3 years ago

Right now, the default is azureuser and is in the variables file. Given that the script accepts admin name for MySQL, let's follow the same approach

selvasingh commented 3 years ago

CLI script prompts for VM admin name

bash-3.2$ source deploy-azurespringcloud-internal.sh 
Enter full UPN of Key Vault Admin: 
12b6d75b-1df0-4356-ba1f-888cae8973d7
Enter MySql Db admin name: 
selvasingh
Enter MySql Db admin password: 
XXX
Enter Jumpbox VM admin name: 
selvasingh
Enter Jumpbox VM admin password: 
XXX
{
  "id": "/subscriptions/1c638cf4-608f-4ee6-b680-c329e824c3a8/resourceGroups/sc-corp-rg",
  "location": "eastus2",
  "managedBy": null,
  "name": "sc-corp-rg",
  "properties": {
    "provisioningState": "Succeeded"
  },
  "tags": null,
  "type": "Microsoft.Resources/resourceGroups"
}
dapolloxp commented 3 years ago

default parameter value has been removed. Jumpbox admin will not be prompted for.