search

Azure / azure-sqldb-spark

This project provides a client library that allows Azure SQL DB or SQL Server to act as an input source or output sink for Spark jobs.
MIT License
76 stars 52 forks source link

Set Scala versions using properties #72

Closed Fokko closed 4 years ago

Fokko commented 4 years ago

Make sure that we set the Scala version at a single place, and that makes it easier to override the properties to set the Scala version of our liking.

arvindshmicrosoft commented 4 years ago

@Fokko would you please rebase / merge your work against current master so that we can do a clean merge post approval?

Fokko commented 4 years ago

Thanks, @arvindshmicrosoft for the review, I've swapped the properties.

arvindshmicrosoft commented 4 years ago

Thanks @Fokko - apologies but it looks like your latest commit did not really change to the desired behavior. Can you double-check?

arvindshmicrosoft commented 4 years ago

Hello again @Fokko - could you please double-check your latest commit? It seems to not have the correct property names as we discussed. As previously mentioned we would like to have scala.version as 2.11 and scala.binary.version to include the minor version i.e. 2.11.8

Fokko commented 4 years ago

@arvindshmicrosoft I misinterpreted your comment, and I disagree with the suggestion. I would keep it congruent with Spark: https://github.com/apache/spark/blob/master/pom.xml#L164