search

Azure / azure-storage-cpp

Microsoft Azure Storage Client Library for C++
http://azure.github.io/azure-storage-cpp
Apache License 2.0
131 stars 147 forks source link

Please review: Static code analysis results by coverity #244

Open yxiang92128 opened 5 years ago

yxiang92128 commented 5 years ago

Our organization requires us to scan all open source SDKs by coverity. After excluding benign/false positive issues and other performance related issues such as Passing large sized parameter by value, I've patched several issues shown as attached mainly in the areas:

Uninitialized member variables.
Uncaught exceptions.
Unchecked return values

Can somebody please verify and if possible integrate the patches?

Thanks. azure_storage_cpp_coverity_patches.txt

katmsft commented 5 years ago

I think @EmmaZhu is currently investigating on it. Please stay tuned.

EmmaZhu commented 5 years ago

Hi @yxiang92128 ,

The change seems fine to me. Could you send a PR to us?

Thanks Emma

yxiang92128 commented 5 years ago

Hi @EmmaZhu ,

Currently we don't the test/unittest infrastructure set up in our dev environment (SLES12SP3). Would you be able to merge the patch into your dev branch and prepare a PR?

Thanks,

Yang

EmmaZhu commented 5 years ago

@yxiang92128 I've created a PR for your change. Could you help to take a reviewing to see whether there's anything I missed?

https://github.com/Azure/azure-storage-cpp/pull/256

Thanks Emma