Azure / azure-storage-cpp

Microsoft Azure Storage Client Library for C++
http://azure.github.io/azure-storage-cpp
Apache License 2.0
132 stars 147 forks source link

Add a public set_storage_credentials method in cloud_client #303

Open scharan opened 4 years ago

scharan commented 4 years ago

This is useful/needed to swap between primary and secondary shared access keys without recreating the client, in conjunction with retries and retry handling in azure::storage::operation_context::set_response_received.

katmsft commented 4 years ago

Hi, thanks for the contribution! Can you elaborate the user scenario needed to swap between keys when retrying? Also, this change will make the cloud_client loose thread-safety. If it the use case can be justified, the PR still needs to be modified so that the cloud_client is thread safe.