Closed ShippyMSFT closed 4 years ago
Hi @ShippyMSFT , thanks for pointing out the potential bug. It's very insightful.
There have been unobserved exception errors for a long time in this sdk.
I just wonder, when will provider.close()
throw? Did you actually fix a crash issue with this change?
Hello, @JinmingHu-MSFT . Yes, this change fixes a crashing issue we see due to an unobserved exception in low memory conditions.
@JinmingHu-MSFT Thanks. I'm new to GitHub. How do I get these merged in and does Azure:dev make it into the main branch at some point?
@ShippyMSFT You don't need to do anything. Before next release, we are going to do some tests and merge it. Thanks for your contribution.
If buffer_task throws and provider.close() throws, it will lead to an unobserved exception error. Retrieve the buffer_task result first to avoid this.