'buff' const-correctness in upload_block_from_buffer()

Azure / azure-storage-cpplite

Lite version of C++ Client Library for Microsoft Azure Storage

MIT License

25 stars 44 forks source link

Closed joe-maley closed 4 years ago

joe-maley commented 4 years ago

The 'buff' argument does not need to be mutable. The const qualfier makes the interface more flexible because it can now handle const input buffers.

msftclas commented 4 years ago

All CLA requirements met.

Jinming-Hu commented 4 years ago

/AzurePipelines run Azure.azure-storage-cpplite

azure-pipelines[bot] commented 4 years ago

Azure Pipelines successfully started running 1 pipeline(s).

joe-maley commented 4 years ago

The CI failed with what appears to be a flaky failure. I'll see if I can re-trigger the CI with the same command

joe-maley commented 4 years ago

/AzurePipelines run Azure.azure-storage-cpplite

azure-pipelines[bot] commented 4 years ago

Commenter does not have sufficient privileges for PR 64 in repo Azure/azure-storage-cpplite

Jinming-Hu commented 4 years ago

The CI failed with what appears to be a flaky failure. I'll see if I can re-trigger the CI with the same command

That is because latest vcpkg doesn't compile with VS2015. Never mind, think of it as passed.

Jinming-Hu commented 4 years ago

/AzurePipelines run Azure.azure-storage-cpplite

azure-pipelines[bot] commented 4 years ago

Azure Pipelines successfully started running 1 pipeline(s).

Jinming-Hu commented 4 years ago

Merged, thanks for your contribution @joe-maley .