search

Azure / azure-storage-java

Microsoft Azure Storage Library for Java
https://docs.microsoft.com/en-us/java/api/overview/azure/storage
MIT License
189 stars 163 forks source link

Updated BlobRequestOptions.java #519

Open sjoshi570 opened 4 years ago

sjoshi570 commented 4 years ago

singleBlobPutThresholdInBytes property default size is mentioned as 32 MB.

The default threshold size is set in the client and is by default 32MB. You can change the threshold size on this request by setting this property.

I have updated this one to 132 MB. As per the discussion I had with MSFT Storage SMEs, this is a documentation bug.

(256 1024 1024) / 2 = 134217728‬, this is what the default threshold size is coming.

Follow below Teams link for more details: https://teams.microsoft.com/l/message/19:3e1c65a38017478b86ad318bf03a1f65@thread.skype/1576580014301?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=8a6a0fe1-0d7d-41a0-93f0-0fd7af9ac2c8&parentMessageId=1576505277402&teamName=PaaS%20Developer%20POD%20Global&channelName=Storage&createdTime=1576580014301

rickle-msft commented 4 years ago

@sjoshi570 Thank you for catching this doc bug and submitting a fix. Although there is some skew involved when looking at the exact number of bytes, I think we would prefer to use 128MB as that is a more accurate representation of 256MB/2. If you could update it accordingly, we would be happy to merge this.