Azure / azure-storage-net

Microsoft Azure Storage Libraries for .NET
Apache License 2.0
445 stars 370 forks source link

Truncate visiblityTimeout when updating QueueMessage #1053

Open marstr opened 2 years ago

marstr commented 2 years ago

The server will reject requests that do not use an integer value of seconds for visiblity. The AddMessage method already addresses this by using a long number of seconds, but UpdateMessage takes a TimeSpan and will include fractional seconds allowing for requests that will always be rejected. This PR addresses the problem by truncating any fractional seconds when creating a Queue request.

marstr commented 2 years ago

Side note - it looks like CONTRIBUTING.md is out of date. dev and dev_breaking are considerably behind the default branch.