Allow both guzzle 6.x and 7.x

Azure / azure-storage-php

Microsoft Azure Storage Library for PHP

MIT License

217 stars 200 forks source link

Allow both guzzle 6.x and 7.x #255

Closed sadika9 closed 3 years ago

sadika9 commented 4 years ago

fixes #248 fixes #253

ghost commented 4 years ago

All CLA requirements met.

jakubovitz commented 4 years ago

@sadika9 @XiaoningLiu @katmsft One approval separates us from solving all issues 😄

andrei-dascalu commented 4 years ago

Also looking forward to this

XiaoningLiu commented 4 years ago

/azp run

azure-pipelines[bot] commented 4 years ago

Azure Pipelines successfully started running 1 pipeline(s).

XiaoningLiu commented 4 years ago

To be included into next Nov. release.

rdgout commented 3 years ago

When is this going to be merged? It's been november for some time 😄

helders commented 3 years ago

Merge time!

MrThePlague commented 3 years ago

@XiaoningLiu Not to be a pest, but is there any chance this is going to be merged within the next few days? There are a number of projects which require this fix in order to support Laravel 8+.

patrickatkeylogic commented 3 years ago

I might be totally missing something but it's still not working for me.

I'm not sure if this is causing my issue but the release repo for azure-storage-common-php still only allows guzzle 6.0: https://github.com/Azure/azure-storage-common-php/blob/master/composer.json

This is a fresh installation of Laravel 8. I can provide more details if they are needed.

WouterSioen commented 3 years ago

This change is merged into the master branch but not released yet, so that's why it's not working yet. Waiting for a release!

bnock commented 3 years ago

Seriously?! I've been waiting for over a month for this simple update to be released so I can upgrade to Laravel 8. I see above that I'm not the only one. What's the hold up? Release this already!!!

For the record, Guzzle 7 has been out since June and Laravel 8 has been out since September, so this library is wayyy behind on its support.

hmazter commented 3 years ago

@bnock FYI you don't need to update to Guzzle 7 to upgrade to Laravel 8. Laravel 8 works with both Guzzle 6 and 7 From the composer.json for laravel/framework

guzzlehttp/guzzle: ^6.5.5|^7.0.1

bnock commented 3 years ago

@hmazter thanks for pointing this out. My issue was trying to follow the Laravel upgrade guide which explicitly says to update your project's composer.json requirement to guzzlehttp/guzzle: ^7.0.1. So, someone like myself just trying to follow the guide AND use this library would run into issues.

That being said, this fix was supposed to go out in November and now we're almost halfway through December so I still question: what's the hold up?