search

Azure / azure-storage-php

Microsoft Azure Storage Library for PHP
MIT License
217 stars 198 forks source link

#295 Add missing x-ms-blob-type header to createFile and createFileFromContents requests #296

Open bimsonz opened 3 years ago

bimsonz commented 3 years ago

This PR closes #295 to the best of my knowledge.

I've removed headers that make the request fail, these could be required and the configuration could be missing elsewhere but this was the success I had testing and fixing this with limited knowledge of the blob storage api.

I've also added the additional and seemingly missing x-ms-blob-type header. The value is fixed to BlockBlob as this felt most appropriate for this operation based on https://docs.microsoft.com/en-us/azure/storage/blobs/storage-blobs-introduction#blobs

ghost commented 3 years ago

CLA assistant check
All CLA requirements met.

bimsonz commented 3 years ago

@katmsft any chance you or one of your colleagues could have a look at this please?

bimsonz commented 3 years ago

/azp run

azure-pipelines[bot] commented 3 years ago
Commenter does not have sufficient privileges for PR 296 in repo Azure/azure-storage-php
bimsonz commented 3 years ago

@XiaoningLiu any chance you or one of your colleagues could have a look at this please?

katmsft commented 3 years ago

I think this is a usage error on file service instead of the blob service for block blob. Are you trying to use it for ADLS Gen 2?