search

Azure / azure-storage-python

Microsoft Azure Storage Library for Python
https://azure-storage.readthedocs.io
MIT License
339 stars 241 forks source link

Re-definition of _StorageSharedKeyAuthentication breaks mypy #539

Closed sfc-gh-afedorov closed 5 years ago

sfc-gh-afedorov commented 5 years ago

Which service(blob, file, queue) does this issue concern?

storage

Which version of the SDK was used? Please provide the output of pip freeze.

azure-common==1.1.14 azure-nspkg==2.0.0 azure-storage==0.36.0

What problem was encountered?

mypy stops with a "Cycle in inheritance hierarchy" when trying to scan package

Have you found a mitigation/solution?

yes, remove these two lines — https://github.com/Azure/azure-storage-python/blob/master/azure-storage-common/azure/storage/common/_auth.py#L77-L78

Note: for table service, please post the issue here instead: https://github.com/Azure/azure-cosmosdb-python.

zezha-msft commented 5 years ago

Hi @andrey-snowflake, thanks for your feedback! We can fix this in the next release.

Btw I see that you are using an outdated version of the SDK (0.36.0 which is now deprecated). Would you like to upgrade to the latest version?

sfc-gh-afedorov commented 5 years ago

Indeed we seem to have already and I was relying on an older snowflake-connector-python. new one is all better, thanks!

xiafu-msft commented 5 years ago

Hi @andrey-snowflake The release by this Friday(7/12/2019) should be able to fix the problem you met! Close the issue currently, feel free to reopen that is you have further questions!

Thanks again for pointing this out and providing a solution!